Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: feegrant module #244

Merged
merged 2 commits into from
Oct 13, 2023
Merged

Conversation

shane-moore
Copy link
Collaborator

Changes

  • support for MsgGrantAllowance and MsgRevokeAllowance native messages from the cosmos sdk feegrant module were added to sdk-ts
  • note that MsgGrantAllowance was built to support BasicAllowance type, which allows for the user to specify an expiration date and which coins they want the grantee to be able to use for transaction fees, and for how long they can use them.
  • jest test cases were built out for MsgGrantAllowance and MsgRevokeAllowance along with examples in the gitbook docs
  • some context was added to MsgExecuteContractCompat to detail why we should use this message for ethereum wallet signing

Testing Complete

  • MsgGrantAllowance and MsgRevokeAllowance example tsx's were successfully broadcasted to chain via:
    • primary key tsx signing via node
    • keplr and metamask wallet signing via msgBroadcaster.broadcast and msgBroadcaster.broadcastWithFeeDelegation
    • jest test cases pass as well

@bangjelkoski bangjelkoski changed the base branch from dev to docs/update-examples October 13, 2023 07:47
@bangjelkoski bangjelkoski merged commit 18f2ddb into docs/update-examples Oct 13, 2023
1 check passed
@bangjelkoski bangjelkoski deleted the chore/msgGrantAllowance branch October 13, 2023 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants